Skip to content

chore(parser): add parser to release steps #2382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Apr 17, 2024
Merged

chore(parser): add parser to release steps #2382

merged 7 commits into from
Apr 17, 2024

Conversation

am29d
Copy link
Contributor

@am29d am29d commented Apr 16, 2024

Description of your changes

This PR adds the necessary configurations so we can release @aws-lambda-powertools/parser package as a beta in the next release.

Related issues, RFCs

Issue number: closes #2366

Checklist

  • My changes meet the tenets criteria
  • I have performed a self-review of my own code
  • I have commented my code where necessary, particularly in areas that should be flagged with a TODO, or hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my change is effective and works
  • The PR title follows the conventional commit semantics

Breaking change checklist

Is it a breaking change?: NO

  • I have documented the migration process
  • I have added, implemented necessary warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@am29d am29d requested a review from a team April 16, 2024 15:55
@am29d am29d requested a review from a team as a code owner April 16, 2024 15:55
@am29d am29d linked an issue Apr 16, 2024 that may be closed by this pull request
Maintenance: prepare parser for beta release #2366
Closed
2 tasks
@boring-cyborg boring-cyborg bot added automation This item relates to automation internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) labels Apr 16, 2024
@pull-request-size pull-request-size bot added the size/S PR between 10-29 LOC label Apr 16, 2024
dreamorosi
dreamorosi approved these changes Apr 16, 2024
View reviewed changes
Copy link
Contributor

@dreamorosi dreamorosi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this, looking forward to release this as beta!

@dreamorosi
Copy link
Contributor

If you want to wait to merge it, tomorrow morning I can try running the lerna & pack commands locally and we can use this PR to fix any issue.

If instead you have already tested and know it works, merge away!

@am29d
Copy link
Contributor Author

am29d commented Apr 16, 2024

You are right, let me first have the dry run tomorrow and then I can merge.

@dreamorosi dreamorosi self-requested a review April 16, 2024 20:36
dreamorosi
dreamorosi requested changes Apr 16, 2024
View reviewed changes
Copy link
Contributor

@dreamorosi dreamorosi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to also set the "publishConfig" to "access": "public" in the package.json file of the utility, or it won't be published to npmjs.com.

Also we should change the keywords to something like:

"keywords": [
    "aws",
    "lambda",
    "powertools",
    "parser",
    "zod",
    "parse",
    "events",
    "payloads",
    "inputs",
    "validate",
    "validation",
    "serverless",
    "typescript",
    "nodejs"
  ],

@dreamorosi
Copy link
Contributor

I also think we should put back disclaimers on the utility's README and docs page to call out that it's still in beta, that we'd like feedback, and that its API might change.

@boring-cyborg boring-cyborg bot added the dependencies Changes that touch dependencies, e.g. Dependabot, etc. label Apr 17, 2024
@pull-request-size pull-request-size bot added size/M PR between 30-99 LOC and removed size/S PR between 10-29 LOC labels Apr 17, 2024
@dreamorosi dreamorosi self-requested a review April 17, 2024 08:04
dreamorosi
dreamorosi approved these changes Apr 17, 2024
View reviewed changes
Copy link
Contributor

@dreamorosi dreamorosi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing the comments - I manually built the package & tested it in a function and basic features seem to work.

I have a couple questions but we can address them in the coming weeks, nothing blocking imo

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@am29d am29d merged commit 8145bc1 into main Apr 17, 2024
11 checks passed
@am29d am29d deleted the chore/parser-prepare-for-release branch April 17, 2024 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dreamorosi dreamorosi dreamorosi approved these changes

Assignees

@am29d am29d

Labels
automation This item relates to automation dependencies Changes that touch dependencies, e.g. Dependabot, etc. internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) size/M PR between 30-99 LOC
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Maintenance: prepare parser for beta release
2 participants
@am29d @dreamorosi